Bug in the x264 2-Pass Multi-Pass CRF script

[johnny808]

I'm on the latest Mediacoder x64 0.8.33.5680.

When I select x264 2-Pass Multi-Pass CRF, I get an error 14 for the second pass. Upon closer inspection of the script:

Code: Select all

x264_opencl --no-progress --preset faster --keyint 250 --min-keyint 25 --no-dct-decimate --non-deterministic --opencl --psy-rd 1:0 --crf 18 --sar 1:1 --threads 12   --stats "$(PassLogFile)" --pass 1 -o "$(DestFile)" -
x264_opencl --no-progress --preset faster --keyint 250 --min-keyint 25 --no-dct-decimate --non-deterministic --opencl --psy-rd 1:0 --bitrate $(VideoBitrate) --qcomp 0.9 --sar 1:1 --threads 12   --stats "$(PassLogFile)" --pass 2 -o "$(DestFile)" -

You can see that the script for pass1 wrongly ends with:

Code: Select all

--pass 1 -o "$(DestFile)" -

The correct ending for pass1 should have been

Code: Select all

 --pass 1 -o NUL -

Only pass 2 should write to the destination file.

[johnny808]

Is everything okay with Stanley?

Today is 7 Jan 2015 and I haven't seen Stanley put out a single post since 15 nov 2014. He's the driving force behind it all.
With the limited knowledge I have, I was still able to point out an obvious bug above, but haven't heard anything back.

[saikat007saha]

I'm on the latest Mediacoder x64 0.8.33.5680.

When I select x264 2-Pass Multi-Pass CRF, I get an error 14 for the second pass. Upon closer inspection of the script:

Code: Select all

x264_opencl --no-progress --preset faster --keyint 250 --min-keyint 25 --no-dct-decimate --non-deterministic --opencl --psy-rd 1:0 --crf 18 --sar 1:1 --threads 12   --stats "$(PassLogFile)" --pass 1 -o "$(DestFile)" -
x264_opencl --no-progress --preset faster --keyint 250 --min-keyint 25 --no-dct-decimate --non-deterministic --opencl --psy-rd 1:0 --bitrate $(VideoBitrate) --qcomp 0.9 --sar 1:1 --threads 12   --stats "$(PassLogFile)" --pass 2 -o "$(DestFile)" -

You can see that the script for pass1 wrongly ends with:

Code: Select all

--pass 1 -o "$(DestFile)" -

The correct ending for pass1 should have been

Code: Select all

 --pass 1 -o NUL -

Only pass 2 should write to the destination file.

I have the same thoughts.

I posted in the bug section.

I think the last part should not contain the $bitrate thing also
as it should take the bitrate from the log file of the first pass.